NCIOCPL / ncids

NCI Design System
7 stars 5 forks source link

Some documentation site examples changed with USWDS 3.0 #832

Closed bryanpizzillo closed 10 months ago

bryanpizzillo commented 1 year ago

Issue description

ESTIMATE TBD

As part of the wide changes for USWDS we had to update the documentation site's index.scss. As such, a number of things were removed causing issues on the font design-tokens page.

olitharp-nci commented 1 year ago

Bryan and I did some investigating, adding our findings here for whenever we pick this up again

  1. Turn on all font utility classes

    $font-palettes: ("palette-font"),
    $font-weight-palettes: ("palette-font-weight"),
  2. Add missing imports

    @import 'uswds/dist/scss/packages/usa-table';
    @import './scss/uswds-site.scss';
    @import './scss/markdown-heading';
    @import './scss/inline-code';

    Note the above code was copy pasta'd from v1.3.0 and should be updated with @forwards and you know, correct pathing. Also also, usa-table will need to be added to ncids-css

  3. The above uswds-site.scss file was just completely deleted and needs to be brought back -- because apparently when I update things, ripping things out that doesn't seem to be needed brings me joy.