search

NCPP / ocgis

OpenClimateGIS is a set of geoprocessing and calculation tools for CF-compliant climate datasets.
Other
70 stars 19 forks source link

Support for discrete geometries in netCDF output #459

Closed huard closed 7 years ago

huard commented 7 years ago

Supports netCDF output for multiple geometries, provided that aggregate is True. Instead of saving the results on an x/y grid, the results are stored along one geometric dimension. This would allow users to, for example, save the monthly mean temperature per country in a single file.

bekozi commented 7 years ago

Thank you much @huard. I'll dive into this over the next few days.

bekozi commented 7 years ago

@huard, could you enable push access to this PR at your leisure? It would be nice to get minor edits as part of the merge... Thanks!

bekozi commented 7 years ago

@huard, there are some Python 3 related failures: https://travis-ci.org/NCPP/ocgis/jobs/269585613#L2065. I think you should be able to just do a list(ugids)[0]. Python 2.7 does not have any problems.

bekozi commented 7 years ago

Looking good! I'll make a push to expand on the output format documentation you added in the next couple days.

bekozi commented 7 years ago

@huard This is ready to merge. I thought that the additional output format descriptions fit better in the appendix so moved them there and deleted the output.rst file. Let me know if you're okay with the changes.

huard commented 7 years ago

All good. I may have put description before calculate, but that's a minor point.

bekozi commented 7 years ago

Ha, yeah, that makes way more sense.

huard commented 7 years ago

Thanks!