search

NCPP / ocgis

OpenClimateGIS is a set of geoprocessing and calculation tools for CF-compliant climate datasets.
Other
70 stars 21 forks source link

Wrong percentiles in ICCLIM indices ? #472

Closed huard closed 6 years ago

huard commented 7 years ago

Shouldn't the percentiles for the last two classes below be 90 ? library_icclim.py

class IcclimTG90p(AbstractIcclimPercentileDictionaryIndice):
    key = 'icclim_TG90p'

    percentile = 90

class IcclimTX90p(AbstractIcclimPercentileDictionaryIndice):
    key = 'icclim_TX90p'

    percentile = 10

class IcclimTN90p(AbstractIcclimPercentileDictionaryIndice):
    key = 'icclim_TN90p'

    percentile = 10
bekozi commented 7 years ago

I agree this looks very wrong. @pagecp, could you confirm?

pagecp commented 7 years ago

Yes, indeed, it should be 90...

bekozi commented 7 years ago

Thanks @pagecp. @huard were you planning to prepare a PR?

huard commented 7 years ago

I could do that. No problem.

On Wed, Nov 29, 2017 at 3:19 PM Ben Koziol notifications@github.com wrote:

Thanks @pagecp https://github.com/pagecp. @huard https://github.com/huard were you planning to prepare a PR?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NCPP/ocgis/issues/472#issuecomment-347983817, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE9Q_nJ1JM1fluMyoQUr7DwfyKaG3unks5s7bxRgaJpZM4Qvbtz .

bekozi commented 6 years ago

Fixed by @huard in #474