NCRN / ForestVeg

Front end application for NCRN Forest Vegetation Access database.
3 stars 1 forks source link

Species With BOTH Shrub & Tree Habit? #129

Open blcampbell opened 5 years ago

blcampbell commented 5 years ago

This is a follow-on data check from #103 to see if there are any situations where we were either missing the habit value or there is a mismatch since the value had previously been set by the user. As a result of that check, it became clear that a check on tlu_Plants was also warranted (the same species was listed as a shrub for one record an tree for another).

Several species are setup in tlu_Plants to have both the Tree AND Shrub habit.

@lizmatthews03, @johnpauls, @abrolis
Please check if all of the species listed SHOULD be setup as having BOTH habits (both tree and shrub).

All species In the list below have both Tree and Shrub set as habits. All appear as a Tree in the habit dropdown on the saplings tab (since all are marked as Tree and the underlying code looks for trees first, they all appear as Tree)

TSN Latin_Name 18042 Cupressaceae Family 19038 Ulmaceae Family 19358 Quercus ilicifolia 19465 Betulaceae Family 22528 Salix eriocephala 22546 Salix humilis 22554 Salix lucida 23463 Ericaceae Family 24538 Rosaceae Family 24763 Prunus americana 24768 Prunus angustifolia 24774 Prunus domestica 24806 Prunus virginiana 25108 Amelanchier spp. 25296 Pyrus pyrifolia 26198 Robinia viscosa 28773 Rhus copallina 28823 Toxicodendron vernix 28989 Poncirus trifoliata 28992 Ptelea trifoliata 32927 Oleaceae Family 194883 Taxus baccata 194886 Taxus cuspidata 500059 Fabaceae Family 505297 Sorbus hybrida 999999 Unknown

Since #103 has been automated, it is important that this aspect is corrected at the same time to avoid data that requires fixing moving forward.

lizmatthews03 commented 5 years ago

I've added comments below for each taxon that is in tlu_Plants as both the Tree AND Shrub. The "low-resolution" taxa (e.g., anything at the "Family" level) should be kept as having both habits, since the habit will vary by species. At the time of sampling, I'd suggest taking all of the "tree" measurements, (so it's good that they all appear as a Tree in the habit drop down), since we only record a sub-set of the data for shrubs.

TSN Latin_Name 18042 Cupressaceae Family 19038 Ulmaceae Family 19358 Quercus ilicifolia -- listed in protocol as a shrub (and I agree with the protocol's treatment!) 19465 Betulaceae Family 22528 Salix eriocephala -- I don't know this species, but based on a quick google search and knowing other Salix, I'd treat it as a shrub. Most Salix species grow as multi-stemmed individuals. Add all Salix spp. to shrub table of protocol. 22546 Salix humilis --same reasoning as above. Go with shrub 22554 Salix lucida --same reasoning as above. Go with shrub 23463 Ericaceae Family 24538 Rosaceae Family 24763 Prunus americana --shrub --> add to shrub table in protocol 24768 Prunus angustifolia --shrub --> add to shrub table in protocol 24774 Prunus domestica --I don't know this species (very rare exotic in our area), but a quick review of species descriptions suggests treating it as a tree 24806 Prunus virginiana --shrub --> add to shrub table in protocol 25108 Amelanchier spp. --protocol says tree, and I won't disagree 25296 Pyrus pyrifolia --I don't know this species (very rare exotic in our area), but a quick review of species descriptions suggests treating it as a tree 26198 Robinia viscosa --I don't know this species well, but I lean towards calling it a Tree 28773 Rhus copallina --go with Tree for now, although I can imagine places 28823 Toxicodendron vernix --shrub, simply so that the field crew can avoid touching this toxic tree. We should add this species to the shrub table in the protocol 28989 Poncirus trifoliata --shrub --> add to shrub table in protocol 28992 Ptelea trifoliata --shrub --> add to shrub table in protocol 32927 Oleaceae Family 194883 Taxus baccata --tree 194886 Taxus cuspidata --tree 500059 Fabaceae Family 505297 Sorbus hybrida --tree 999999 Unknown --for the same reason that we should treat low resolution taxa as Trees, I think Unknown should default to Tree

Liz Matthews, PhD Botanist National Capital Region Network Inventory and Monitoring National Park Service https://www.nps.gov/im/ncrn/index.htm https://www.nps.gov/im/ncrn/index.htm email: elizabeth_matthews@nps.gov office: 202-339-8303 cell: 828-337-2946

On Mon, May 20, 2019 at 3:26 PM Bonnie Campbell notifications@github.com wrote:

This is a follow-on data check from #103 https://github.com/NCRN/ForestVeg/issues/103 to see if there are any situations where we were either missing the habit value or there is a mismatch since the value had previously been set by the user. As a result of that check, it became clear that a check on tlu_Plants was also warranted (the same species was listed as a shrub for one record an tree for another).

Several species are setup in tlu_Plants to have both the Tree AND Shrub habit.

@lizmatthews03 https://github.com/lizmatthews03, @johnpauls https://github.com/johnpauls, @abrolis https://github.com/abrolis Please check if all of the species listed SHOULD be setup as having BOTH habits (both tree and shrub).

All species In the list below have both Tree and Shrub set as habits. All appear as a Tree in the habit dropdown on the saplings tab (since all are marked as Tree and the underlying code looks for trees first, they all appear as Tree)

TSN Latin_Name 18042 Cupressaceae Family 19038 Ulmaceae Family 19358 Quercus ilicifolia 19465 Betulaceae Family 22528 Salix eriocephala 22546 Salix humilis 22554 Salix lucida 23463 Ericaceae Family 24538 Rosaceae Family 24763 Prunus americana 24768 Prunus angustifolia 24774 Prunus domestica 24806 Prunus virginiana 25108 Amelanchier spp. 25296 Pyrus pyrifolia 26198 Robinia viscosa 28773 Rhus copallina 28823 Toxicodendron vernix 28989 Poncirus trifoliata 28992 Ptelea trifoliata 32927 Oleaceae Family 194883 Taxus baccata 194886 Taxus cuspidata 500059 Fabaceae Family 505297 Sorbus hybrida 999999 Unknown

Since #103 https://github.com/NCRN/ForestVeg/issues/103 has been automated, it is important that this aspect is corrected at the same time to avoid data that requires fixing moving forward.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCRN/ForestVeg/issues/129?email_source=notifications&email_token=AB6LHDW66YIVUR3YMBQKGMDPWL3OZA5CNFSM4HOEXZRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUZSOOA, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LHDWVZJXIHL4FNYJ3UOLPWL3OZANCNFSM4HOEXZRA .

blcampbell commented 5 years ago

Since the last note on unknowns states: "for the same reason that we should treat low resolution taxa as Trees, I think Unknown should default to Tree"

Clarifying: What I'm looking for is whether these species should have both their Tree and Shrub flags in tlu_Plants changed to being only Tree or only Shrub.

The application already accommodates those which are set as both Shrub & Tree in tlu_Plants by defaulting them to Tree in the sapling Habit dropdown.

@lizmatthews03 please confirm:

_With this clarification are there any changes for the tlu_Plants flags from what you've noted above?_

tlu_Plants Changes Based on species adjustments noted above, tlu_Plants flags will be adjusted as follows...

Sapling Habit Dropdown Behavior The application will continue to handle habits based on the tlu_Plant Tree and Shrub flags, defaulting those which have both checked to Tree in the dropdown. Species where only Shrub is checked in tlu_Plants will default to Shrub.

A user can still select Shrub (or Tree) for any species. So while these default based on tluPlants they do not fully restrict a user from making an incorrect - or correct -_ choice (based on tlu_Plants).

Data Alignment Overall, sapling data should be congruent and match with tlu_Plants flags. There shouldn't be a situation where the habit flag for a sapling is set to a flag that doesn't match with the species' Tree/Shrub flags in tlu_Plants.

Instances where habit is either unclear (i.e. could be Tree or Shrub) or potentially could be either Tree or Shrub should probably remain set with both Tree and Shrub flags in tlu_Plants.

lizmatthews03 commented 5 years ago

Using the three categories described above, I've updated the actions for each TSN Latin_Name currently in tlu_Plants with both Tree and Shrub flags. (This is consistent with the content in my previous comment, but hopefully clearer and easier to interpret!)

18042 Cupressaceae Family --both (no change) 19038 Ulmaceae Family --both (no change) 19358 Quercus ilicifolia -- Shrub - set Shrub flag only 19465 Betulaceae Family --both (no change) 22528 Salix eriocephala -- Shrub - set Shrub flag only 22546 Salix humilis --Shrub - set Shrub flag only 22554 Salix lucida --Shrub - set Shrub flag only 23463 Ericaceae Family --both (no change) 24538 Rosaceae Family --both (no change) 24763 Prunus americana -- Shrub - set Shrub flag only 24768 Prunus angustifolia -- Shrub - set Shrub flag only 24774 Prunus domestica --Tree - set Tree flag only 24806 Prunus virginiana -- Shrub - set Shrub flag only 25108 Amelanchier spp. --Tree - set Tree flag only 25296 Pyrus pyrifolia --Tree - set Tree flag only 26198 Robinia viscosa --Tree - set Tree flag only 28773 Rhus copallina --Tree - set Tree flag only 28823 Toxicodendron vernix -- Shrub - set Shrub flag only 28989 Poncirus trifoliata -- Shrub - set Shrub flag only 28992 Ptelea trifoliata -- Shrub - set Shrub flag only 32927 Oleaceae Family --both (no change) 194883 Taxus baccata --Tree - set Tree flag only 194886 Taxus cuspidata --Tree - set Tree flag only 500059 Fabaceae Family --both (no change) 505297 Sorbus hybrida --Tree - set Tree flag only 999999 Unknown --both (no change)