NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Do not treat warnings as errors while coding #105

Closed nulltoken closed 3 weeks ago

nulltoken commented 3 weeks ago

Pull request description

PR meta checklist

Code PR specific checklist

:wave: This one is a very minor one. It actually aims at making the project a bit easier to onboard.

The rationale being, while working on a contribution, I'm not sure pestering the developer about XML comments and code style is the best approach. The proposal is to relax the "WarningsAsErrors" rule while coding.

As the CI is configured to build in Release mode, those warnings will eventually be fixed in order to get the pull request merged.

But it will allow one to scratch an itch, play with NCronJob code without cursing too much at the compiler while spiking something :wink:

linkdotnet commented 3 weeks ago

You are absolutely right and I appreciate the PR.