NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Remove IJobHistory #110

Closed nulltoken closed 3 weeks ago

nulltoken commented 3 weeks ago

Pull request description

Currently, JobExecutor feeds a NoOpHistory, registered in the DI container by AddNCronJob().

The IJobHistory interface being internal, this registration can't be later replaced with a custom concrete type by users of the library with knowledge of its internal implementation.

The README explicitly states "There is no history of jobs that have been run."

This cleans the codebase from a section of useless code.

However, would this be a stepping stone for a feature to come, feel free to ignore this code change proposal and close this PR.

PR meta checklist

Code PR specific checklist

linkdotnet commented 3 weeks ago

The idea was to build a system for the Dashboard (or something which lets you look inside the state). It is for the better that we remove this. Not sure if I would need this if we tackle that feature.

So thanks for the good work @nulltoken