NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Only publish coverage against one target framework #116

Closed nulltoken closed 3 weeks ago

nulltoken commented 3 weeks ago

Pull request description

Coverage reports seem... a bit unstable (see https://github.com/NCronJob-Dev/NCronJob/pull/114#issuecomment-2450888724 for instance).

Currently the tests are run for both net8.0 and net9.0. As such two different coverage reports are submitted to coveralls. Maybe this dual reporting is what generates the "instability".

This proposed change runs the tests once again, for the sole purpose of coverage analysis, but by only targeting net8.0.

PR meta checklist

Code PR specific checklist

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11627901069

Details


Files with Coverage Reduction New Missed Lines %
src/NCronJob/Scheduler/ObservablePriorityQueue.cs 1 91.38%
src/NCronJob/Scheduler/JobProcessor.cs 3 73.08%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 11627027565: -0.5%
Covered Lines: 1025
Relevant Lines: 1170

💛 - Coveralls
nulltoken commented 3 weeks ago

This seems to clear up some fog and (hopefully) should provide a less fluctuating baseline.

Before: image

With this change: image

linkdotnet commented 3 weeks ago

Interesting. Until now we don't have any. net9.0 exclusive stuff (besides System.Threading.Lock). So let's roll with it