Remove dependencies upon removing a job

NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.

https://docs.ncronjob.dev/

MIT License

158 stars 11 forks source link

Remove dependencies upon removing a job #119

Closed nulltoken closed 2 weeks ago

nulltoken commented 2 weeks ago

Pull request description

Fix #107

PR meta checklist

[x] Pull request is targeted at main branch for code
[x] Pull request is linked to all related issues, if any.

Code PR specific checklist

[x] My code follows the code style of this project and AspNetCore coding guidelines.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] I have updated the appropriate sub section in the CHANGELOG.md.
[x] I have added, updated or removed tests to according to my changes.
- [x] All tests passed.

coveralls commented 2 weeks ago

coverage: 84.31% (-0.06%) from 84.365% when pulling ac02403f2e098af9a57736df3de18579c3b2820c on nulltoken:ntk/drop_deps into 252336c17c5a4607f80637480966e9eb22db57ec on NCronJob-Dev:main.

linkdotnet commented 2 weeks ago

Love it and will merge it.

PS: Would it make things easier for you to be "Contributor" and be basically part of the NCronJob-Dev org?

linkdotnet commented 2 weeks ago

Maybe one nitpick: Can you add an entry to the changelog.md that explains your fix (plus giving you credit)? (Under the UNRELEASED section).

nulltoken commented 2 weeks ago

Can you add an entry to the changelog.md that explains your fix (plus giving you credit)? (Under the UNRELEASED section).

Done.

nulltoken commented 2 weeks ago

Can you add an entry to the changelog.md that explains your fix (plus giving you credit)? (Under the UNRELEASED section).

Done.

I took the liberty to also cleanup the changelog file a bit:

Target the NCronJob-Dev organization
Fix tag names in compare links

nulltoken commented 2 weeks ago

PS: Would it make things easier for you to be "Contributor" and be basically part of the NCronJob-Dev org?

That'd be nice. Thanks for the proposal!

linkdotnet commented 2 weeks ago

Can you add an entry to the changelog.md that explains your fix (plus giving you credit)? (Under the UNRELEASED section).

Done.

I took the liberty to also cleanup the changelog file a bit:

Target the NCronJob-Dev organization

Fix tag names in compare links

Thanks - Initially it was a deliberate choice to keep the old name, mainly:

Some of the releases (everything prior 2.5 or so) is not under the NCronJob namespace and package
I see the changelog as "append" only in the majority of cases. But it also doesn't hurt either - so let's roll with it

linkdotnet commented 2 weeks ago

Feel free to merge