Ensure multiples schedules of the same job with different chains of dependent jobs are properly processed

NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.

https://docs.ncronjob.dev/

MIT License

158 stars 11 forks source link

Ensure multiples schedules of the same job with different chains of dependent jobs are properly processed #124

Closed nulltoken closed 2 weeks ago

nulltoken commented 2 weeks ago

Pull request description

This partly fixes #108 with regards to not properly honoring different dependent schedules.

However, this doesn't deal with the other broader concerns (for instance, how to selectively run an instant job targeting a specified configured schedule among other ones).

PR meta checklist

[x] Pull request is targeted at main branch for code
[x] Pull request is linked to all related issues, if any.

Code PR specific checklist

[ ] My code follows the code style of this project and AspNetCore coding guidelines.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] I have updated the appropriate sub section in the CHANGELOG.md.
[x] I have added, updated or removed tests to according to my changes.
- [x] All tests passed.

coveralls commented 2 weeks ago

coverage: 84.767% (+0.5%) from 84.31% when pulling 8fba306d4c40342243df790c41059cb08d912f2e on nulltoken:ntk/different_deps_schedules into e6e4053aba2591abec228f6ecbfaf1d258191935 on NCronJob-Dev:main.

linkdotnet commented 2 weeks ago

One test seems to be stuck:

linkdotnet commented 2 weeks ago

Locally I can't reproduce the hanging test, but when running via Github Codespace, it also sometimes hangs. Just doesn't show the current executed test.

nulltoken commented 2 weeks ago

Locally I can't reproduce the hanging test, but when running via Github Codespace, it also sometimes hangs. Just doesn't show the current executed test.

On it.

nulltoken commented 2 weeks ago

Locally I can't reproduce the hanging test, but when running via Github Codespace, it also sometimes hangs. Just doesn't show the current executed test.

On it.

Can't repro either. Rebased and added some xunit configuration to list hanging tests in the future.

linkdotnet commented 2 weeks ago

I'll try to reproduce via the Codespace. Just FYI: You can also use codespaces with 120 CPU hours for free.

linkdotnet commented 2 weeks ago

It happes on the Codespace only on net9.0:

CanBuildAChainOfDependentJobsThatRunAfterOneJob

nulltoken commented 2 weeks ago

It happes on the Codespace only on net9.0: <img alt="image" width="1165" src="https://private-user-

CanBuildAChainOfDependentJobsThatRunAfterOneJob

Thanks for the identification. I'll take a look at it tomorrow.

nulltoken commented 2 weeks ago

It happes on the Codespace only on net9.0: <img alt="image" width="1165" src="https://private-user- CanBuildAChainOfDependentJobsThatRunAfterOneJob

Thanks for the identification. I'll take a look at it tomorrow.

Actually, couldn't resist. So I took a quick peek.

The hanging problem seems unrelated to this PR as it can be reproduced on Codespaces against the main branch.

linkdotnet commented 2 weeks ago

It happes on the Codespace only on net9.0: <img alt="image" width="1165" src="https://private-user- CanBuildAChainOfDependentJobsThatRunAfterOneJob

Thanks for the identification. I'll take a look at it tomorrow.

Actually, couldn't resist. So I took a quick peek.

The hanging problem seems unrelated to this PR as it can be reproduced on Codespaces against the main branch.

Interesting! Thanks for the heads up! Well - probably it is fine if we tackle it on main then.

nulltoken commented 2 weeks ago

Interesting! Thanks for the heads up! Well - probably it is fine if we tackle it on main then.

Tracked through #125

nulltoken commented 2 weeks ago

Changelog has been updated as well.

linkdotnet commented 2 weeks ago

Good work! I will directly make a new release!