search

NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

fix: Don't silently ignore duplicates #129

Closed linkdotnet closed 2 weeks ago

linkdotnet commented 2 weeks ago

Fixes #128

coveralls commented 2 weeks ago

Coverage Status

coverage: 87.444% (-0.2%) from 87.629% when pulling 4e7b922e4c1739fbbc4389c6d5bd4a6226401e78 on fix/#128 into 37cac19dc7affefedb3c5e42c836263c6309bdac on v4.

linkdotnet commented 2 weeks ago

Should now include all the changes. After the merge I will rebase v4

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...Job/Configuration/Builder/NCronJobOptionBuilder.cs 50.00% 1 Missing :warning:
Files with missing lines Coverage Δ
src/NCronJob/Registry/JobRegistry.cs 95.87% <100.00%> (+0.27%) :arrow_up:
src/NCronJob/Registry/RuntimeJobRegistry.cs 97.14% <100.00%> (+0.26%) :arrow_up:
...Job/Configuration/Builder/NCronJobOptionBuilder.cs 88.28% <50.00%> (+0.58%) :arrow_up:

... and 1 file with indirect coverage changes

nulltoken commented 2 weeks ago

Great job! :clap:

linkdotnet commented 2 weeks ago

Great job! 👏

Thanks for sticking around :D that was harder than it looked :D