Ensure parameter handling is coherent

[nulltoken]

Pull request description

Minor change in parameter handling to ensure that a job parameter value can be overridden through the InstantJobRegistry.

PR meta checklist

• [x] Pull request is targeted at main branch for code
• [ ] Pull request is linked to all related issues, if any.

Code PR specific checklist

• [x] My code follows the code style of this project and AspNetCore coding guidelines.
• [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
• [x] I have updated the appropriate sub section in the CHANGELOG.md.
• [x] I have added, updated or removed tests to according to my changes.
  • [x] All tests passed.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines	Coverage Δ
src/NCronJob/Registry/JobRun.cs	83.82% <100.00%> (ø)

[linkdotnet]

Interesting - which case does that cover which wasn't covered before?

[nulltoken]

Interesting - which case does that cover which wasn't covered before?

This one. I stumbled onto this while digging deeper into what were the elements of a JobDefinition uniqueness.

Definition of a job with a standard "configuration" (passed through the parameter). Temporary overriding of that job "configuration" at runtime through the one-of execution of the job.

    [Fact]
    public async Task InstantJobCanOverrideInitiallyDefinedParameter()
    {
        ServiceCollection.AddNCronJob(
            n => n.AddJob<ParameterJob>(o => o.WithCronExpression("* * 31 2 *").WithParameter("Hello from AddNCronJob")));

        var provider = CreateServiceProvider();
        await provider.GetRequiredService<IHostedService>().StartAsync(CancellationToken);

        provider.GetRequiredService<IInstantJobRegistry>().RunInstantJob<ParameterJob>("Hello from InstantJob");

        var content = await CommunicationChannel.Reader.ReadAsync(CancellationToken);
        content.ShouldBe("Hello from InstantJob");
    }

The other tests were added/modified to have a more comprehensive suite in that context.

[linkdotnet]

Thanks for the clarification!

[nulltoken]

@linkdotnet Changelog has been updated