Closed nulltoken closed 2 weeks ago
Attention: Patch coverage is 96.15385%
with 1 line
in your changes missing coverage. Please review.
Files with missing lines | Patch % | Lines |
---|---|---|
...Job/Configuration/Builder/NCronJobOptionBuilder.cs | 50.00% | 1 Missing :warning: |
Files with missing lines | Coverage Δ | |
---|---|---|
src/NCronJob/Registry/JobRegistry.cs | 95.87% <100.00%> (+0.27%) |
:arrow_up: |
src/NCronJob/Registry/RuntimeJobRegistry.cs | 97.14% <100.00%> (+0.26%) |
:arrow_up: |
...Job/Configuration/Builder/NCronJobOptionBuilder.cs | 88.28% <50.00%> (+0.58%) |
:arrow_up: |
LOL - I like the story ;)
It looks like I did an oopsie-whoopsie when rebasing the main on v4 and dropped the whole commit.
Pull request description
Historians say something BAD™ happened during the "Great Rebase of v4", in early November of 2024. A lot of work has been lost then. Ton of hair has been pulled out in vain. #129 suffered the most of this.
Although it's unclear what caused this, thanks to the ability to download git patches from a Github PR and the magic of
git-apply
, the Code™ has been salvaged and carefully restored.These "Lost-then-Found" magical diffs are now re-introduced to the public audience for the first time since then.
Note: Although I authored this PR, the identity of the original author of this work has been restored in the signature of the commit.
PR meta checklist
main
branch for codeCode PR specific checklist