NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Make UseNCronJobAsync() mandatory when startup jobs have been defined #136

Closed nulltoken closed 2 weeks ago

nulltoken commented 2 weeks ago

Pull request description

Follow up to https://github.com/NCronJob-Dev/NCronJob/pull/121#discussion_r1826658953

Slight enhancement to control of startup jobs.

The lib will now throw on startup only when:

No change at the doc level were required as no wording was hinting to UseNCronJobAsync being optional.

This should prevent some misconfiguration at the user level.

PR meta checklist

Code PR specific checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines Coverage Δ
src/NCronJob/NCronJobExtensions.cs 97.29% <ø> (ø)
src/NCronJob/Scheduler/QueueWorker.cs 70.58% <100.00%> (+2.54%) :arrow_up: