Open nulltoken opened 2 weeks ago
@linkdotnet Not all tests are passing.
Before going further with how the code should be changed to make them pass, I'd like some feedback from you about the following points:
Note: I haven't wandered in the region of dynamic jobs. Yet. Before diving into that, I'd like to ensure "how the lib should behave with 'simpler' jobs" is defined.
I will have a look at this at the end of the week - unfortunately I am a bit swamped with stuff.
Attention: Patch coverage is 69.56522%
with 7 lines
in your changes missing coverage. Please review.
Files with missing lines | Patch % | Lines |
---|---|---|
...CronJob/Configuration/Builder/DependencyBuilder.cs | 41.66% | 5 Missing and 2 partials :warning: |
Files with missing lines | Coverage Δ | |
---|---|---|
src/NCronJob/Registry/JobRegistry.cs | 96.15% <100.00%> (+0.27%) |
:arrow_up: |
...CronJob/Configuration/Builder/DependencyBuilder.cs | 65.00% <41.66%> (-35.00%) |
:arrow_down: |
Pull request description
@linkdotnet Early work in the land of #108
Not a real PR as of now, rather a test bed for expectations (and tests that we'd like to see passing).
PR meta checklist
main
branch for codeCode PR specific checklist