NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Create abstraction around `JobExecutionContext` to hide some implemenation details #59

Closed linkdotnet closed 2 months ago

linkdotnet commented 6 months ago

In #53 by @falvarez1 the JobExecutionContext has some internal details we don't want to expose. That includes the whole construction of the object itself.

To keep the current contract stable and let users be able to test their code, we had to add a ctor that mimics the old behavior. That isn't a very nice way. The much cleaner approach is to create a IJobExecutionContext interface with the public stuff and make JobExecutionContext internal.

ToDo

linkdotnet commented 2 months ago

Done on v3