search

NCronJob-Dev / NCronJob

A Job Scheduler sitting on top of IHostedService in dotnet.
https://docs.ncronjob.dev/
MIT License
158 stars 11 forks source link

Use Microsoft.Extensions.Hosting.Abstractions #74

Closed chrisls121 closed 5 months ago

chrisls121 commented 5 months ago

Currently this package references Microsoft.Extensions.Hosting which causes a lot of redundant implicit dependances to be added.

Using Microsoft.Extensions.Hosting.Abstractions greatly reduces the implicit dependances.

I could not find much supporting documentation about the *.Abstractions packages but found a fairly concise explanation on Stack Overflow.

linkdotnet commented 5 months ago

That is an excellent idea @chrisls121 There is no real reason to use the non-abstraction package rather than I didn't think of using it in the first place!

That said, I will make a new release soon that drops that dependency!

Much appreciated

linkdotnet commented 5 months ago

I merged the change - If it is urgent for you, I can create a new release right away, otherwise I would probably add 1 or 2 more features for a new release.

linkdotnet commented 5 months ago

Fixed by #75

chrisls121 commented 5 months ago

Thanks @linkdotnet! It is not urgent, I will wait for the new release.

linkdotnet commented 5 months ago

From 2.6.4-preview this change will be included. If you are willing to add a pre-release, you can "test" the change.

chrisls121 commented 5 months ago

Thanks for the quick resolution, it's working great.