search

ND-Framework / ND_Core

ND Framework core
https://discord.gg/nC82d8zvjM
GNU General Public License v3.0
53 stars 37 forks source link

getPlayerServerInfo returns nil #45

Closed realCallMeJ closed 8 months ago

realCallMeJ commented 9 months ago

NDCore.getPlayerServerInfo(source) appears to always return nil, which would probably be the cause behind not being able to see departments in ND_Characters when they have a discord role ID, even if you have a matching role ID

heres how im checking this (in case ive done something wrong) code: image output: image

Andyyy7666 commented 9 months ago

I've fixed this, does it work for you? https://github.com/ND-Framework/ND_Core/commit/4b106d36889e68d8f9090614922859e2a6ad7433

Andyyy7666 commented 9 months ago

The issue was caused only when joining because the old temporary source was a string

realCallMeJ commented 9 months ago

yes, that has fixed the main part of the issue however, i noticed that this hasn't resolved the problem i mentioned with ND_Characters after a little more testing, it appears that when attempting to retrieve discord role info through getPlayerServerInfo, it returns nil unless the core has been restarted code: image output before core restart: image output after core restart: image

Andyyy7666 commented 9 months ago

I dont seem to have this problem, I’ll check again and see if I can find what’s causing this for you, you’re on the latest files right?

realCallMeJ commented 9 months ago

yeah, i have the latest files and i've just double checked to make sure here's a video that shows the issue better: https://medal.tv/games/gta-v/clips/1JApsZcKd81tKO/d1337lyFaqxY?invite=cr-MSx5WGQsMzczNjk4LA