ND-Framework / ND_Core

ND Framework core
https://discord.gg/nC82d8zvjM
GNU General Public License v3.0
53 stars 37 forks source link

/pay & Invoices #51

Closed ValenciaModifcations closed 8 months ago

ValenciaModifcations commented 8 months ago

Describe the bug Without having the correct amount of money in cash, if you /pay somebody, they wrill recieve your money... lol

Also, invoices are bugged and will not allow you to pay them.

To Reproduce Steps to reproduce the behavior:

  1. Have a test subject, have 2500 in cash.
  2. /pay 8000
  3. Check money amount.
  4. See problem.

Expected behavior /pay is refused due to insufficent funds.

Legacy-TacticalGamingInteractive commented 8 months ago

Describe the bug Without having the correct amount of money in cash, if you /pay somebody, they wrill recieve your money... lol

Also, invoices are bugged and will not allow you to pay them.

To Reproduce Steps to reproduce the behavior:

  1. Have a test subject, have 2500 in cash.
  2. /pay 8000
  3. Check money amount.
  4. See problem.

Expected behavior /pay is refused due to insufficent funds.

What is your inventory money amount. Is it the same as your ND hud amount or is it not syncing? Just asking for research purposes based on a different bug that might be related or not

ValenciaModifcations commented 8 months ago

The only way to check money is via Banks or Pause Menu in our server.

Andyyy7666 commented 8 months ago

This should be fixed, I haven't had time to test it tho: https://github.com/ND-Framework/ND_Core/commit/d939607d6451995d8a2ea93d97c2b1ce993bbef3

Also invoices would be related to ND Banking

Andyyy7666 commented 8 months ago

invoices issue moved to: https://github.com/ND-Framework/ND_Banking/issues/3