search

NDAR / nda-tools

Python package for interacting with NDA web services. Used to validate, submit, and download data to and from NDA.
MIT License
48 stars 22 forks source link

update example and usage info for -dp/--package flag #10

Open agt24 opened 5 years ago

agt24 commented 5 years ago

Fix to example in README.md and in usage info based on info from @obenshaindw in help ticket #97692

obenshaindw commented 5 years ago

@agt24 these changes in argparse aren't compatible with subsequent logic for how downloadcmd 'decides' what it should be doing. I am working on a local branch that updates that logic to be compatible with variables rather than boolean True/False 'flags', which is how the tool's logic currently works.

See https://github.com/NDAR/nda-tools/blob/30ce227f2b6384862676d6632dfb01260312a135/NDATools/clientscripts/downloadcmd.py#L81 for what I'm referring to.

Also coming up with some basic integration tests as @yarikoptic pointed out, there are no tests so it's hard to tell if changes break anything.