Open agt24 opened 5 years ago
@agt24 these changes in argparse aren't compatible with subsequent logic for how downloadcmd 'decides' what it should be doing. I am working on a local branch that updates that logic to be compatible with variables rather than boolean True/False 'flags', which is how the tool's logic currently works.
See https://github.com/NDAR/nda-tools/blob/30ce227f2b6384862676d6632dfb01260312a135/NDATools/clientscripts/downloadcmd.py#L81 for what I'm referring to.
Also coming up with some basic integration tests as @yarikoptic pointed out, there are no tests so it's hard to tell if changes break anything.
Fix to example in README.md and in usage info based on info from @obenshaindw in help ticket #97692