search

NDAR / nda-tools

Python package for interacting with NDA web services. Used to validate, submit, and download data to and from NDA.
MIT License
48 stars 22 forks source link

git tag the releases #19

Open yarikoptic opened 4 years ago

yarikoptic commented 4 years ago

there are versions in CHANGELOG but not a single git tag.

Note: better git tag -a locally, since github doesn't generate annotated tags for the releases

yarikoptic commented 3 years ago

uff... I am having "up to date" master and it says

$> vtcmd
Running NDATools Version 0.2.0
Your version of nda-tools is out of date. Please install the latest version (0.2.2) from PyPi or GitHub and try again.

changelog here https://github.com/NDAR/nda-tools/blob/master/CHANGELOG.md#020---2020-04-07 has 0.2.0 as the latest. So where from GitHub I should install from?
I do indeed see 0.2.2 on pypi -- was it just forgotten git push? once again -- please tag the releases!

RogLee commented 3 years ago

Hi Yaroslav, the version in the source code is 0.2.0 which does not match with the automatically incremented version in PyPI (0.2.2). They're the same source code. I'll fix the versions later tonight or tomorrow morning and I'll see about adding the git tags.

Thanks! Roger

yarikoptic commented 3 years ago

Great -- thank you in advance!

Could you please point me to a piece of machinery on "automatically incremented version in PyPI"? I am curious since I never saw such a thing I think... we usually first either modify version in the sources and then tag, or use smth like versioneer to tag and make it produce version -- and then upload to pypi already knowing what version would be.

RogLee commented 3 years ago

The version is now 0.2.3 in both the source code and on PyPI. PyPI does not allow version replacements so the build number is incremented by one.

I do agree that the version in the code should be updated first and the build process should extract that version and create a tag. The tag has been created by has not been pushed to the GitHub quite yet. On the next release, the deployment plan will extract the tag from our repository and push the tag to GitHub.