search

NDAR / nda-tools

Python package for interacting with NDA web services. Used to validate, submit, and download data to and from NDA.
MIT License
48 stars 22 forks source link

Fix bug in which scope argument is treated as list instead of string #31

Closed jacob-lee closed 3 years ago

jacob-lee commented 3 years ago

My submission with custom scope was failing, not recognizing the column aliases I was using; when I tried validating using the online web tool, it validated successfully. So I ran with the pdb debugger and saw that the scope argument resolved to the first character of the scope or collection ID I was submitting under. When I made the proposed change, the data successfully validated, and I was able to submit using nda-tools.

I note that the argument parser for --scope indicates that the type is str, so it seemed a safe fix to create a pull request on.

jacob-lee commented 3 years ago

Referenced to issue: https://github.com/NDAR/nda-tools/issues/34

aburr-nimh commented 3 years ago

Good afternoon, we have merged this, but unfortunately we cannot seem to get GitHub to mark this as successfully merged. Here is a link to your commit in the repository: https://github.com/NDAR/nda-tools/commit/8b41252e2afd761cffba2629660bb32cc3e4b2ca we'll be marking this pull request as closed (as well as the issue associated with it). Thank you for your contribution.