Closed F-said closed 2 years ago
Pasting in comments to @yanbin-niu made on slack (sorry, we should stop discussing on slack and keep our discussions on here!) :)
@DMRoberts @F-said comments/thoughts welcome!!
Hey @yanbin-niu looking at this again... I wonder if there might actually be a dc offset that is accounting for this. I.e. for the period where the data is all at greater than -1000 the variation is still in the normal range.
Is it possible that the highpass filter has an issue? I.e. not actually filtering at the freqs we want. Or, perhaps the filter is being run across discontinuous segments, causing the issue? Is the highpass run for just a single continuous segment?
Lastly, I think if we remove the mean amplitude of each epoch prior to the threshold rejection, this should solve the issue.
@DMRoberts thoughts?
@yanbin-niu actually, I believe it is typically not recommended to remove the baseline prior to ica. So, we should really try to tackle this from the filter side. It seems to me that the issue may likely be in the filter somewhere. Either the highpass is not filtering at the proper pass/stob band, or, there is an issue of filtering over discontinuities. I think...
resolved
Describe the bug Function
ica.fit(epochs_prep)
on line 209 occasionally rejects all epochs, such that epochs.events is empty. Results in pipeline crash.Expected behavior Either a skip or some resolution should be implemented.