Minimize exception handling in features, catch exceptions in run and write to dictionary

NDCLab / pepper-pipeline

tool | Python Easy Pre-Processing EEG Reproducible Pipeline

GNU Affero General Public License v3.0

3 stars 3 forks source link

Minimize exception handling in features, catch exceptions in run and write to dictionary #391

Closed F-said closed 2 years ago

F-said commented 2 years ago

Describe the feature effect or output The current run.py structure is convoluted, repeats itself, and does not record all exceptions. Needs to be refactored.

Which part of the pipeline does this satisfy if any Main pipeline

What is the minimum for this feature to be complete?

If statement is gone
All exceptions are logged to output dictionary
(maybe) logging implemented as well?

F-said commented 2 years ago

Reconfigures tests as well. Why bother testing for invalid objects if run.py handles ALL?

Assert that feature creates the expected dictionary. What is the expected dictionary? Ours to define as fixtures