search

NDLANO / eslint-config-ndla-h5p

eslint configuration for H5P content type projects
MIT License
0 stars 0 forks source link

Use something other than ESLint's built-in rules for formatting #5

Open boyum opened 11 months ago

boyum commented 11 months ago

Earlier this year, it was announced that ESLint 9 will not include formatting rules. In the latest version (https://github.com/eslint/eslint/pull/17696) they have deprecated them and they will soon be gone. This project should be updated to support ESLint 9.

The simplest way to fix this is to use @stylistic/eslint-plugin-js which includes the old formatting rules. https://eslint.style/packages/js

otacke commented 11 months ago

Good surveillance of the dev scene!

H5P Group is going to monitor how Stylistic evolves in terms of community based maintenance and use eslint 8 until it's clear what direction makes the most sense for them. They are also considering to create an official configuration on npm then, so I don't think any immediate action needs to be taken here.

otacke commented 11 months ago

Addition: The old rules will not be removed until at least ESlint 10.0.0 (see https://eslint.org/blog/2023/10/deprecating-formatting-rules/), so there really seems to be enough time for assessing the situation.

boyum commented 11 months ago

Thanks for the clarification!

otacke commented 5 months ago

Just a note on top: ESlint 9.0.0 is out, and flat config is set to be the new default (can be overridden by environment variables until ESlint 10.0.0). That means the general configuration will need to be changed a little as well. eslint-plugin-import seems to be close to releasing an update to support ESLint 9, so at least this could be tackled shortly.