NDevTK / AutoPause

Browser extension to pause other audio and video sources if audio is playing on the active tab with automatic resume, fast forward and media controls.
https://addons.mozilla.org/firefox/addon/autopause/
MIT License
31 stars 6 forks source link

Netflix Video Not Working: Blackscreen #31

Closed DecodedMonkey closed 2 years ago

DecodedMonkey commented 2 years ago

Describe the bug When installed and enabled, it causes Netflix to not play video. Audio still plays, just no video output.

To Reproduce Steps to reproduce the behavior:

  1. Install Add-on
  2. Play Video on Netflix
  3. See error

Desktop (please complete the following information):

Extension configuration

Browser configuration

NDevTK commented 2 years ago

Thanks for the report :) I don't have a netflix subscription.

When you press F12 while watching a video is there any errors? Does this affect any other website?

DecodedMonkey commented 2 years ago

Uncaught (in promise) DOMException: Node.removeChild: The node to be removed is not a child of this node

This error disappears when disabling the extension, so I think it is being caused by AutoPause.

NDevTK commented 2 years ago

Without the extension and a video playing... Does this pause the media? [...document.getElementsByTagName('video')].forEach(v => {v.playbackRate = 0}) ;

Does this play the media? [...document.getElementsByTagName('video')].forEach(v => {v.playbackRate = 1});

Does this fix it? https://github.com/NDevTK/AutoPause/actions/runs/3201095010

NDevTK commented 2 years ago

Since this issue seems to be with the extension preventing .play() I added error handling does https://github.com/NDevTK/AutoPause/actions/runs/3201219856 work? If you need help testing it pls say :)

DecodedMonkey commented 2 years ago

The media does Play and pause, using the code snippets.

3201219856 does not seem to fix the issue.

Though, I no longer see any errors in Firefox dev tools.

DecodedMonkey commented 2 years ago

I take that back the error is still there had to refresh a few times though. Not sure what that is about.

I am doing this testing in a clean version of Firefox Dev Edition

NDevTK commented 2 years ago

Did you try https://github.com/NDevTK/AutoPause/actions/runs/3201095010 that should remove the code injection part for netflix.

DecodedMonkey commented 2 years ago

3201095010

Does fix the issue.

NDevTK commented 2 years ago

🎉Okay guess the issue is with WindowScript.js Does the extension still pause the media?

DecodedMonkey commented 2 years ago

Yes, seems to be working as intend.

NDevTK commented 2 years ago

If all goes well I will publish https://github.com/NDevTK/AutoPause/releases/tag/2.7.7 in less then 24 hours. It also includes performance improvements since there was a logic issue with the content script. Also it now pauses hidden muted media.

NDevTK commented 2 years ago

Fixed in version 2.7.7 and published on Firefox.