search

NDxSaber / phpdesktop

Automatically exported from code.google.com/p/phpdesktop
0 stars 0 forks source link

Drawing of the popup window fails on Win XP #72

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Noticed on a clean XP SP3 machine.

Popup windows work fine in cefclient, so this is PHP Desktop only issue.

It seems that the code that causes this bug is when positioning the window. 
When the option "center_relative_to_parent" in settings.json is set to false, 
then the popup window is drawed fine. There is probably missing a call to 
UpdateWindow() after the window was repositioned.

Original issue reported on code.google.com by czarek.t...@gmail.com on 1 Feb 2014 at 12:01

GoogleCodeExporter commented 8 years ago 
Popup windows work fine in MSIE on XP. This is only a Chrome issue.

Original comment by czarek.t...@gmail.com on 1 Feb 2014 at 12:04

GoogleCodeExporter commented 8 years ago 
The the CenterWindowRelativeToParent() function there was a call to 
MoveWindow(), but its last parameter bRepaint was set to FALSE. It needs to be 
set to TRUE to fix the issue.

Original comment by czarek.t...@gmail.com on 1 Feb 2014 at 12:08

GoogleCodeExporter commented 8 years ago 
Fixed in revision c65311dc8f91.

Original comment by czarek.t...@gmail.com on 1 Feb 2014 at 12:14

GoogleCodeExporter commented 8 years ago 
Noticed a minor glitch when popup window appears on Win XP. The window is 
jumping a bit from. Originally it is positioned at 0, 0 and in OnAfterCreated 
it is repositioned, but that happens after the window already appeared. There 
is a comment in OnAfterCreated that explains this behavior:

  // It would be best to provide x,y coordinates in OnBeforePopup,
  // but setting windowInfo.x and windowInfo.y there doesn't work.
  // These coordinates are probably used only when calling SetAsChild().
  // So we have to center it after the window was created.

It may be fixable, but that would require further investigation.

Original comment by czarek.t...@gmail.com on 1 Feb 2014 at 12:17

GoogleCodeExporter commented 8 years ago 
Project will move to Github. Find this issue at the new address (soon): 
https://github.com/cztomczak/phpdesktop/issues/72

Original comment by czarek.t...@gmail.com on 24 Aug 2015 at 3:25