NEAR-DevHub / neardevhub-bos

NEAR DevHub UI hosted on NEAR BOS
https://neardevhub.org
MIT License
24 stars 22 forks source link

Timeline checkboxes wrongly get selected when moving a proposal from Draft to Rejected or Canceled #926

Open ori-near opened 4 weeks ago

ori-near commented 4 weeks ago

Affected Portal: Select one: DevHub

Description: When a proposal is in Draft mode, if I try to move it to Cancel or Reject, I noticed that random Timeline checkboxes get checked (e.g. "Sponsor Verifies KYC/KYB" was checked") that are not supposed to.

User Type: Specify: DevHub Admin

Reproduction Steps

  1. Open a draft proposal (e.g. https://near.social/devhub.near/widget/app?page=proposal&id=102)
  2. Click Admin timeline button
  3. Select the Proposal Status dropdown. Choose Canceled or Rejected.
  4. Notice how various checkboxes get checked under the review stage.

Expected behavior If I move a proposal from Draft to Canceled or Draft to Rejected, none of the other checkboxes should be checked unless I chose them specifically under the Review stage, which is skipped in this case.

Visual Reference See video: https://github.com/user-attachments/assets/36aaed01-3766-43ed-9279-0dff629345b9

Priority Low (P3) – Minor inconvenience

Environment Details

Tguntenaar commented 3 weeks ago

I've created a PR and @Megha-Dev-19 pointed out that this effects the last acceptance criteria of https://github.com/NEAR-DevHub/neardevhub-bos/issues/848, so I will write some tests to that both cases show correct behaviour.