NEAR-DevHub / neardevhub-contract

DevHub Portal Product Contract (Hosted on NEAR Blockchain) – Includes other instances (e.g. Infrastructure, Events)
https://neardevhub.org
19 stars 15 forks source link

Fix post 606 by switching supervisor from AccountId to String in Sponsorship #113

Closed PolyProgrammist closed 6 months ago

PolyProgrammist commented 6 months ago

When trying to get post 606

near contract \
    call-function \
    as-read-only devgovgigs.near get_post \
    json-args '{"post_id": 606}' \
    network-config pagoda-mainnet \
    now

The error occurs:

Error: 
   0: Failed to fetch query for view method: 'get_post' (contract <devgovgigs.near> on network <mainnet>)
   1: Failed to make a view-function call
   2: handler error: [Function call returned an error: wasm execution failed with error: HostError(GuestPanic { panic_msg: "Cannot deserialize element" })]

Note: add_post transaction

Here is why:

So before the change it was possible to add a post with empty supervisor:

near contract \                        
    call-function \
    as-transaction test_606_from_9829f4.testnet add_post \
    json-args '{
  "body": {
    "name": "Kyiv Tech Summit 2023: Web3 Hackathon+Conference",
    "amount": "30000",
    "post_type": "Sponsorship",
    "supervisor": "",         
    "description": "sponsorship on old version without supervisor",
    "sponsorship_token": "USD",
    "sponsorship_version": "V1"
  },
  "labels": [
    "hackathon"
  ]
}' \
    prepaid-gas '300 Tgas' \
    attached-deposit '0.1 NEAR' \
    sign-as test_606_from_9829f4.testnet  \
    network-config testnet \
    sign-with-keychain \
    send

After the change, it became invalid

So, in this PR supervisor field's type is changed from AccountId to simple String. So that there is no type check. It does not break anything. And I don't provide migration as Sponsorship is deprecated

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent update involves modifying the data type of the supervisor field in the Sponsorship and SponsorshipV1 structs from AccountId to String. This change simplifies the representation of supervisor identities, potentially enhancing flexibility and ease of integration in diverse environments.

Changes

File Path Change Summary
.../post/sponsorship.rs Changed supervisor field type from AccountId to String in Sponsorship and SponsorshipV1 structs.

🐇🌟 In the code where bytes once stood, Strings now flow, as they should. A rabbit hopped through fields so wide, Changing IDs with a joyful stride. Hop, skip, a code flip—how grand! A simpler trace through data's land. 🌼🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
PolyProgrammist commented 6 months ago

See devgovgigs branch