NEAR-DevHub / neardevhub-contract

DevHub Portal Product Contract (Hosted on NEAR Blockchain) – Includes other instances (e.g. Infrastructure, Events)
https://neardevhub.org
19 stars 15 forks source link

Notifications should pass the post type #73

Closed elliotBraem closed 10 months ago

elliotBraem commented 11 months ago

This is related to #505 and #504 in neardevhub-widgets repository. The goal is to ensure that the notification links route correctly based on the postType.

In the case of a blog, the postType is a "comment" with no parentId... this was a hack to get Blogs out fast. We may also want to explore formally creating a "Blog" type and migrating existing "blogs" to this type.

Implementation:

  1. Modify notify.rs to ensure that the postType is included alongside the ID in function parameters.

  2. Update notify functions calls to pass the post type (comes from post body)

  3. Either resolve "comment" type with no parentId as "blog", or create a blog type and migrate existing posts.

Tguntenaar commented 11 months ago

I will pick this up now, I can't assign myself, so if someone can do that for me.

Tguntenaar commented 11 months ago

Either resolve "comment" type with no parentId as "blog", or create a blog type and migrate existing posts.

I've been working on creating a blog type and migrate existing posts, but this turns out to be not that straight forward. @ailisp I would like to take another look at with you if you've got time to call. But for now I will resolve to staying with comments without a parent id.

Tguntenaar commented 10 months ago

Closing this issue since notifications will be fixed by using socialdb for proposals