added post_type to notify::notify_mentions

NEAR-DevHub / neardevhub-contract

DevHub Portal Product Contract (Hosted on NEAR Blockchain) – Includes other instances (e.g. Infrastructure, Events)

https://neardevhub.org

19 stars 15 forks source link

added post_type to notify::notify_mentions #81

Closed Tguntenaar closed 10 months ago

Tguntenaar commented 11 months ago

Resolves #73 and unblocks #505

The notify module now passes the post_type to tell what type of post triggered the notification.

As Elliot mentioned here we resolve "comment" type with no parentId as "blog".

I first added a blog as a type for a post but it would imply a new PostBodyV1 a new PostSnapshotV1 and a whole bunch of extra code to migrate without a real gain. Didn't want to overengineer it.

elliotBraem commented 10 months ago

@frol @ailisp this PR looks good to me and resolves the change as I intended it. Could someone review and merge please to unblock the front end PR?

frol commented 10 months ago

I am sorry to jump on it late, but I feel it is pointless to fix this functionality given that we plan to implement announcements, discussions, and proposals using SocialDB posts and thus will gain all the notifications out of the box.

This implementation looks pretty weird to me from the design point of view, but instead of trying to clean it up, I would just drop it.

Tguntenaar commented 10 months ago

Alright will close this PR since we are dropping it