NEAR-DevHub / neardevhub-treasury-dashboard

Frontend for Treasury Dashboard Product (includes DevHub, Infinex) + Testing front end. Note – we leverage Sputnik DAO contract.
MIT License
3 stars 0 forks source link

Add form validation to the amount field and test #80

Closed Tguntenaar closed 1 month ago

Tguntenaar commented 1 month ago

I noticed that

So I added a small function checking this and wrote a test for it

Screenshot 2024-10-18 at 12 13 21

invalid digit

video.webm

Tguntenaar commented 1 month ago

@race-of-sloths include

race-of-sloths commented 1 month ago

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

[

<source media="(prefers-color-scheme: light)" srcset="https://race-of-sloths.com/images/bot-banner-light.svg">
<img alt="Shows inviting banner with latest news." src="https://race-of-sloths.com/images/bot-banner-light.svg">

](https://race-of-sloths.com/latest-news)

[

<source media="(prefers-color-scheme: light)" srcset="https://badge.race-of-sloths.com/Tguntenaar?type=bot&pr=NEAR-DevHub/neardevhub-treasury-dashboard/80&theme=light">
<img alt="Shows profile picture for the author of the PR" src="https://badge.race-of-sloths.com/Tguntenaar?type=bot&pr=NEAR-DevHub/neardevhub-treasury-dashboard/80&theme=white">

](https://race-of-sloths.com/profile/Tguntenaar)

Current status: executed | Reviewer | Score | |--------|--------| | @petersalomonsen | 5 | Your contribution is much appreciated with a final score of 5! You have received 75 (50 base + 15 weekly bonus + 10 monthly bonus) Sloth points for this contribution Congratulations @Tguntenaar! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors: - Tag @race-of-sloths inside your pull requests - Wait for the maintainer to review and score your pull request - Check out your position in the [Leaderboard](https://race-of-sloths.com/leaderboard) - Keep weekly and monthly streaks to reach higher positions - Boast your contributions with a dynamic picture of your [Profile](https://race-of-sloths.com/profile/Tguntenaar) For maintainers: - Score pull requests that participate in the Race of Sloths - Engage contributors with fair scoring and fast responses so they keep their streaks - Promote the Race to the point where the Race starts promoting you - Grow the community of your contributors Feel free to check [our website](https://race-of-sloths.com) for additional details!

Bot commands - For contributors - **Include a PR:** `@race-of-sloths include` to enter the Race with your PR - For maintainers: - **Invite contributor** `@race-of-sloths invite` to invite the contributor to participate in a race or include it, if it's already a runner. - **Assign points:** `@race-of-sloths score [1/2/3/5/8/13]` to award points based on your assessment. - **Reject this PR:** `@race-of-sloths exclude` to send this PR back to the drawing board. - **Exclude repo:** `@race-of-sloths pause` to stop bot activity in this repo until `@race-of-sloths unpause` command is called
petersalomonsen commented 1 month ago

@race-of-sloths score 5