NEAR-Edu / near-certification-tools

2 stars 2 forks source link

feature/account-header-padding `fix: header padding` #10

Closed ozanisgor closed 2 years ago

ozanisgor commented 2 years ago

@ryancwalsh according to https://github.com/NEAR-Edu/near-certification-tools/pull/7#issuecomment-1041509218 #3 I did below changes

  1. Remove scss style for h1 and add tailwind styles.

I hope removing scss style for the h1 is ok. I did this because do responsive is easier with tailwind but if it is not ok I can also search for internet and find how to do it with scss

BEFORE

17 02 22_account_before

AFTER

17 02 22_account_after

ozanisgor commented 2 years ago

@ryancwalsh according to https://github.com/NEAR-Edu/near-certification-tools/pull/7#issuecomment-1042535849 I did below changes.

  1. Cut some space below and above of the h1

When I redueced the font size it was hard to compare spaces that still much or not. If they are still looking much I can cut more.

I just realized this was merged but I am not sure did I made h1 below and above cut before or after the merge. I hope I did't mess

BEFORE

17 02 22_account_h1_spaces_before

AFTER

17 02 22_account_h1_spaces_after

ryancwalsh commented 2 years ago

Yeah https://github.com/NEAR-Edu/near-certification-tools/tree/feature/account-header-padding no longer exists because it was already merged. So I don't see your commits about removing header padding. Push them to whatever branch and open a PR when ready.

ozanisgor commented 2 years ago

@ryancwalsh Sorry for confusion. I just double checked develop branch and noticed my last commit https://github.com/NEAR-Edu/near-certification-tools/pull/10/commits/2402f2281863a3336a73b91e2470bf1b9db60a19 applied before merged. I think I managed to push just before you merge it.

Below I tried to explain.


image

https://github.com/NEAR-Edu/near-certification-tools/blob/develop/web-app/styles/Account.module.scss

image


image

https://github.com/NEAR-Edu/near-certification-tools/blob/develop/web-app/styles/Account.module.scss

image


BEFORE it was looking like this

17 02 22_account_h1_spaces_before

AFTER it looks like this now. Do you think it is enough?

image

ryancwalsh commented 2 years ago

@ozanisgor Oh, yes, great!