search

NEAR-Edu / near-certification-tools

2 stars 2 forks source link

Handle cases where student or instructor mainnet account names are really really long. #14

Closed ryancwalsh closed 2 years ago

ryancwalsh commented 2 years ago

Consider asking Dan for ideas.

ryancwalsh commented 2 years ago

I wonder if https://stackoverflow.com/a/20552063/470749 would help.

norrec99 commented 2 years ago

@ryancwalsh I've been working on this issue. I implemented the functionality from the stackoverflow you mentioned above. But I can't test it because the contract won't render the certs that have accountName which are 25 characters or longer. So for example we can render rashaabdulrazzak.testnet which has 24 characters but we can't render rashaabdulrazzakr.testnet because it is 1 character longer than previous one.

Even though before I implemented the functionality from the stackoverflow, I couldn't render any cert that has a longer accountName. There is no problem about minting the certificate with a longer accountName but the problem is somewhere in the web-app I guess but I couldn't figure it out.

norrec99 commented 2 years ago

Thanks to @rashaabdulrazzak and @ozanisgor we are now able to handle long names with a new function.

Here it looks like this image

ryancwalsh commented 2 years ago

@norrec99 @ozanisgor @rashaabdulrazzak Good job figuring it out, team!

ryancwalsh commented 2 years ago

And good job with the helpful screenshots at https://github.com/NEAR-Edu/near-certification-tools/issues/14#issuecomment-1049007579 @norrec99