search

NEAR-Edu / near-certification-tools

2 stars 2 forks source link

add: custom 404 page #42

Closed norrec99 closed 2 years ago

norrec99 commented 2 years ago

Before image

After image

ryancwalsh commented 2 years ago

Thanks, @norrec99 ! 👏

ryancwalsh commented 2 years ago

@norrec99 Unfortunately I'm not seeing this work yet on my local machine or even on production after merging to main:

image

https://near-certification-tools-tpq1.onrender.com/xxx

image

Can you please look into it and figure out why they don't look like yours?

norrec99 commented 2 years ago

You said "after merging to main" but I can't see any changes on the "main branch"

I can see the changes on the "develop branch" image

but when I switch to the "main branch", the last change was made 13 days ago. image

It seems to me something went not right while merging "develop" into "main"

Can you see the the new 404 page when you are on the "develop branch"?

ryancwalsh commented 2 years ago

This is the merge into main 23 hours ago. Are you sure you pulled main recently?

https://github.com/NEAR-Edu/near-certification-tools/commit/9bdd121981827f28322b2f05674c95f260094e29

ryancwalsh commented 2 years ago

@norrec99 This was my mistake! My apologies!

ryancwalsh commented 2 years ago

@norrec99 https://near-certification-tools-tpq1.onrender.com/xxx now works. Actually, can you please make a new small PR to replace the purple 404 on the left with the word "Error" instead? I generally think showing arbitrary codes to visitors isn't very user-friendly.