search

NEARBuilders / bos-workspace

Local workspace for BOS development
25 stars 24 forks source link

Support "Don't ask again" #114

Closed petersalomonsen closed 4 months ago

petersalomonsen commented 4 months ago

The "Don't ask again" feature does not work with the BOS-workspace gateway.

image

As you can see it is only displaying "Don't ask again for sending similar transactions by", and that's all, but it should also show the widget name.

The reason for this is because of using the redirectmap, and the fix would be to make sure that the RPC proxy intercepts and replaces requests for widget source code with local content ( and stop using the redirectmap ). I know this will work, since I've already tested it in the DevHub playwright tests.

elliotBraem commented 4 months ago

Local gateway is hardcoded with proxy RPC requests (see here)

But is also configured for redirect map here. This is only used for hot reload -- hot reload can be disabled via "bos-workspace dev --no-hot"

Try disabling hot reload and see if it works then

petersalomonsen commented 4 months ago

even with --no-hot I get this:

image
elliotBraem commented 4 months ago

This is resolved now with #115, --no-hot will not trigger redirectMap