search

NEEOInc / neeo-sdk

NEEO Brain SDK
https://neeoinc.github.io/neeo-sdk/
MIT License
48 stars 17 forks source link

Changed getRecipesPowerState to getActiveRecipes #125

Closed gvdhoven closed 6 years ago

gvdhoven commented 6 years ago

in order to match URL on brain which is called. Some files where auto-formatted by Visual Studio Code, sorry for that :)

gvdhoven commented 6 years ago

@MichaelKohler changes done, also in more files of the SDK where there was a space before the parenthesis...

gvdhoven commented 6 years ago

@MichaelKohler done.

MichaelKohler commented 6 years ago

Me again, sorry :(

1) I've tried to apply it to our developer version, but miserably failed. Would you mind updating this to the next branch and update the PR to target our next branch? That might make the whole thing easier and we don't need to manually pick it into our repository and it will always be part of the history :) 2) Something with the index.html changes went wrong here. Can you revert those changes by runningnpm run doc? That should produce an HTML file in dist/doc/ that only has the necessary changes in it. You can then move that file to docs/ and the difference to our next branch should only be the method rename. There is no need to do any code formatting there, as it's auto-generated.

Tested the changes, looks good!

gvdhoven commented 6 years ago

Done. see #127