search

NEEOInc / neeo-sdk

NEEO Brain SDK
https://neeoinc.github.io/neeo-sdk/
MIT License
48 stars 17 forks source link

Add port to devStart.js example #145

Closed enternoescape closed 5 years ago

enternoescape commented 5 years ago

I tried using this example to test a driver I just started working on and was puzzled about the INVALID_STARTSERVER_PARAMETER exception I was getting until I looked at the function throwing the exception and noticed that the port parameter is required. The port is also shown as required in the SDK documentation, so this is the only place I found this error.

neophob commented 5 years ago

Thanks @enternoescape - good catch. We will definitive improve that thanks to your PR. Also the sdk docs (https://neeoinc.github.io/neeo-sdk/?q=start#lib-index.js-module.exports.startserver) shows a correct example

Just a side note for you: using the integrated cli is deprecated (see https://github.com/NEEOInc/neeo-sdk#deprecated-neeo-sdk-cli).

enternoescape commented 5 years ago

@neophob Thanks. There's so much pointing to the neeo-sdk cli that I missed that detail. I mean I read it, but somehow I think I just glossed over it because I was looking for something specific.

neophob commented 5 years ago

fully agree, details matters especially if you dive deep into the code! thanks again @enternoescape