NEEOInc / neeo-sdk

NEEO Brain SDK
https://neeoinc.github.io/neeo-sdk/
MIT License
48 stars 17 forks source link

Added device types. #158

Closed nklerk closed 5 years ago

nklerk commented 5 years ago

I need HDMISWITCH and AUDIO for a project.

These are missing: 'AUDIO', 'HDMISWITCH', 'SOUNDBAR', 'TUNER'

The folowing can give issues: THERMOSTAT, CLIMA

pfiaux commented 5 years ago

These types weren't initially added because they have additional requirements. I think we can include them as long as make sure we document the requirements and add validation.

At least that's my assumption, we'll have to check whether that's still true or not. The missing validation should explain issues if you change the SDK to allow some of these type but without adding the required macros to the devices.

nklerk commented 5 years ago

I’m exposing the HDMISWITCH and AUDIO in my implementation without any noticeable issues. Hope that helps. :-)

pfiaux commented 5 years ago

HDMISWITCH should already be in the nextbranch, as well as TUNER, although I feel like tuner might rely on an INPUT TUNER 1 as a fallback. I'll double check AUDIO.

pfiaux commented 5 years ago

Alright I went through the types and checked for validation and other issues:

I've discussed this with @neophob, the main issues is that this targets the master branch and we're currently focused on the next branch and we want to keep the SDK releases synchronized with the Firmware versions. Other minor points:

Considering this we decided to close this (you should be able to use your fork of the SDK if you need them with the current firmware/sdk version). That said I will add AUDIO and SOUNDBAR into the next release and credit you for the changes ;) to make sure we're caught up on the SDK compatible types.