search

NEFSC / NEFSC-Spatial

http://nefsc.github.io/NEFSC-Spatial
http://nefsc.github.io/NEFSC-Spatial
Other
7 stars 0 forks source link

Adding requested LMA1 Restricted Area #24

Closed jmhatch closed 1 year ago

jmhatch commented 1 year ago

@andybeet requested the shapefile depicting the LMA1 Restricted Area be added to NEFSCSpatial. The following files have been added as requested:

  1. R code to download, process, and save the shapefile is in data-raw/get_nmfs_remote_sf.R
  2. Saved data as sf object in an .rda file located in data/LMA1_Restricted_Area_FR.rda
  3. Documented data in R/data_LMA1_Restricted_Area_FR.R (may need more metadata)
  4. Ran roxygen2 to create .Rd file from documentation in man/LMA1_Restricted_Area_FR.Rd
  5. Updated reference in _pkgdown.yml to include LMA1

Roxygen in DESCRIPTION updated to vers 7.2.3.

andybeet commented 1 year ago

@kimberly-bastille This Looks good. Merge when you get a chance to look it over

@jmhatch The only thing i might suggest going forward is that we put the pkgdown site on its own gh-pages branch and use a GitHub action to build and deploy. This will prevent recommitting files in the doc folder each time we build the site locally

jmhatch commented 1 year ago

@andybeet Thanks. I initially tried to put the pkgdown site on its own gh-pages branch and use a GitHub action to build and deploy, but ran into permission issues. I agree with you and think it's worth looking into again. I'll add an issue so that we don't forget about it.