NEFSC / NEFSC-Spatial

http://nefsc.github.io/NEFSC-Spatial
http://nefsc.github.io/NEFSC-Spatial
Other
7 stars 0 forks source link

Adding requested GSC Restricted Area and LMA1 #26

Closed jmhatch closed 1 year ago

jmhatch commented 1 year ago

@andybeet requested the shapefiles depicting the LMA1 and GSC Restricted Areas be added to NEFSCSpatial. The following files have been added as requested:

  1. R code to download, process, and save the shapefiles are in data-raw/get_nmfs_remote_sf.R
  2. Saved data as sf objects in .rda files located in data/LMA1_Restricted_Area_FR.rda and data/Great_South_Channel_Restricted_Trap_Pot_Area.rda
  3. Documented data in R/data_LMA1_Restricted_Area_FR.R (may need more metadata) and R/data_Great_South_Channel_Restricted_Trap_Pot_Area.R (may need more metadata)
  4. Ran roxygen2 to create .Rd files from documentation in man/LMA1_Restricted_Area_FR.Rd and man/Great_South_Channel_Restricted_Trap_Pot_Area.Rd
  5. Updated reference in _pkgdown.yml to include LMA1 and GSC

I updated data-raw/create_sf_data_from_url.R to replace hyphens with underscores in the exported data object name, since hyphens can cause issues loading data objects (which I didn't realize until now).

Resolves #21 and #22.

jmhatch commented 1 year ago

Trying out another one! I'll leave the last request for someone else.

andybeet commented 1 year ago

@jmhatch Thanks for the bug fix in 1data-raw/create_sf_data_from_url.R`. One thing i noticed, all of the content from the un-merged pull request 24 also resides in this pull request. I suspect you may have made a branch from a branch. Not sure how this will play out once PR 24 is merged. Maybe we should merge PR 24 and find out?

jmhatch commented 1 year ago

@andybeet That's my mistake. I must of branched off of my branch, when I meant to branch off of main. We could try to merge both PR #24 and then this PR and see what happens. Or just close PR #24 and then merge this PR? I'm fine with whatever. I'll try not to branch off of branches in the future :sweat_smile:.

andybeet commented 1 year ago

@jmhatch ok so lets merge this one. i just added both issues to this PR. We can then just close 24. @kimberly-bastille is too busy right now so let's just try and get this workflow down and she can jump on board when her plate is less full

jmhatch commented 1 year ago

@andybeet Sounds good, and thanks for doing that!