Closed jmhatch closed 1 year ago
Trying out another one! I'll leave the last request for someone else.
@jmhatch Thanks for the bug fix in 1data-raw/create_sf_data_from_url.R`. One thing i noticed, all of the content from the un-merged pull request 24 also resides in this pull request. I suspect you may have made a branch from a branch. Not sure how this will play out once PR 24 is merged. Maybe we should merge PR 24 and find out?
@andybeet That's my mistake. I must of branched off of my branch, when I meant to branch off of main. We could try to merge both PR #24 and then this PR and see what happens. Or just close PR #24 and then merge this PR? I'm fine with whatever. I'll try not to branch off of branches in the future :sweat_smile:.
@jmhatch ok so lets merge this one. i just added both issues to this PR. We can then just close 24. @kimberly-bastille is too busy right now so let's just try and get this workflow down and she can jump on board when her plate is less full
@andybeet Sounds good, and thanks for doing that!
@andybeet requested the shapefiles depicting the LMA1 and GSC Restricted Areas be added to NEFSCSpatial. The following files have been added as requested:
data-raw/get_nmfs_remote_sf.R
sf
objects in.rda
files located indata/LMA1_Restricted_Area_FR.rda
anddata/Great_South_Channel_Restricted_Trap_Pot_Area.rda
R/data_LMA1_Restricted_Area_FR.R
(may need more metadata) andR/data_Great_South_Channel_Restricted_Trap_Pot_Area.R
(may need more metadata)roxygen2
to create.Rd
files from documentation inman/LMA1_Restricted_Area_FR.Rd
andman/Great_South_Channel_Restricted_Trap_Pot_Area.Rd
reference
in_pkgdown.yml
to include LMA1 and GSCI updated
data-raw/create_sf_data_from_url.R
to replace hyphens with underscores in the exported data object name, since hyphens can cause issues loading data objects (which I didn't realize until now).Resolves #21 and #22.