search

NEFSC / NEFSC-Spatial

http://nefsc.github.io/NEFSC-Spatial
http://nefsc.github.io/NEFSC-Spatial
Other
7 stars 0 forks source link

added a R-cmd-check workflow #42

Open andybeet opened 1 year ago

andybeet commented 1 year ago

R-CMD-check.yml

This creates additonal issues to correct. Some of which are done here.

OTHER STUFF TO FOLLOW

jmhatch commented 1 year ago

I think compressing large data files is a good idea, @andybeet! I did a quick check and it looks like the *.rda files are already compressed, but maybe not optimal? I also changed data/Herring_Management_Areas.rda and data/NAFO_Divisions_2021_line_enclosed.rda to have bzip2 compression (they were gzip, while everything else was bzip2). I think this R pkg is going to be big.

> ## paths to *.rda images
> paths <- sort(Sys.glob('data/*.rda'))
> 
> ## check compression
> chk_comp <- tools::checkRdaFiles(paths)
> chk_comp
                                                          size ASCII compress version
data/amapps_grid.rda                                     35462 FALSE    bzip2       2
data/BTS_Strata.rda                                     925563 FALSE    bzip2       2
data/EcoMon_Strata.rda                                  364960 FALSE    bzip2       2
data/epu_sf.rda                                         438176 FALSE    bzip2       2
data/final_mass_inshore_stat.rda                       1418389 FALSE    bzip2       2
data/GillnetClosureAreas_20211021.rda                     1742 FALSE    bzip2       2
data/Great_South_Channel_Restricted_Trap_Pot_Area.rda     1785 FALSE    bzip2       2
data/Herring_Management_Areas.rda                      4451806 FALSE    bzip2       3
data/LMA1_Restricted_Area_FR.rda                          1410 FALSE    bzip2       2
data/NAFO_Divisions_2021_line_enclosed.rda              105254 FALSE    bzip2       3
data/NAFO_Divisions_2021_line_not_enclosed.rda           86527 FALSE    bzip2       2
data/NAFO_Divisions_2021_poly_clipped.rda              3005125 FALSE    bzip2       2
data/NAFO_Divisions_2021_poly_not_clipped.rda           106522 FALSE    bzip2       2
data/Shellfish_Strata.rda                               108757 FALSE    bzip2       2
data/Shrimp_Strata.rda                                   25715 FALSE    bzip2       2
data/Statistical_Areas_2010.rda                       12492084 FALSE    bzip2       2
data/Statistical_Areas_2010_withNames.rda             12500689 FALSE    bzip2       2
andybeet commented 7 months ago

@jmhatch how did you change the compression from gzip to bzip2?