NEFSC / READ-EDAB-neusAtlantis

https://github.com/NEFSC/READ-EDAB-neusAtlantis/wiki
https://github.com/NEFSC/READ-EDAB-neusAtlantis/wiki
Other
5 stars 0 forks source link

Updated Age Structure & Calibration #228

Closed jcaracappa1 closed 8 months ago

jcaracappa1 commented 8 months ago

Summary

Updated age structured functional groups to properly reflect life history and calibrated groups to resemble v2.0.2. Parameters changed include:

neus_groups.csv: NumCohorts and NumAgeClassSize at_biology.prm: rescaled mum, C, & FSPB; age_mat at_harvest.prm: CatchTS_agedistrib neus_init.nc: initial ResN, StructN, and Numbers

Also includes improvements to cloud calibration workflow & various calibration parameter changes. Groups with different age structure: MAK, HER, WHK, BLF, WPF, SUF, WIF, WTF, HAL, PLA, BUT, ANC, GOO, MEN, COD, SHK, OHK, POL, RHK, TYL, RED, OPT, SAL, STB, TAU, WOL, TYF, DOG, SMO, SSH, DSH, BLS, POR, WSK, LSK, SB, REP, RWH, BWH, and TWH

NOTE: MAK is crashing but needs to be addressed in a future update

Individual Changes

Organization

Parameter Files

R Scripts

data files

Other

jcaracappa1 commented 8 months ago

@RGamble1 @andybeet Please take time to review somewhat carefully. There are a lot of changes made throughout parameters and calibration scripts to accommodate the new age structured groups. Attached is the run comparison between dev. 6536_cloud_new_age_PRModel_Comparison_Biomass.pdf

RGamble1 commented 8 months ago

Joe, this was a lot of work. Thanks, and it looks good to me. @andybeet , @jcaracappa1

andybeet commented 8 months ago

looks good. great documentation. thanks for that. i will need to update the postprocessing package to include some of those changes. Maybe this might be a good time for the group to understand how to update/develop R packages. maybe we need to combine packages. maybe we need to thing about adding calibration tools also.