v2.2.0 Age Structure and v6681 Code Update

NEFSC / READ-EDAB-neusAtlantis

https://github.com/NEFSC/READ-EDAB-neusAtlantis/wiki

Other

5 stars 0 forks source link

v2.2.0 Age Structure and v6681 Code Update #244

Closed jcaracappa1 closed 5 months ago

jcaracappa1 commented 6 months ago

Uses Atlantis codebase v6681

Summary

Contains all pull requests from #228 to #243
Updated age structure of functional groups with associated age-based parameter changes in neus_groups.csv, at_biology.prm, at_harvest.prm, and neus_init.nc
Updated code-base to v6681, with additional new parameters and a new neus_migrations.csv
General calibration of v6681 biology.prm to match previous release calibration criteria
Bug fixes and development of cloud calibration workflow

jcaracappa1 commented 6 months ago

I added a brief summary. We should expand as needed. This is where we get the release notes from

andybeet commented 6 months ago

I'm running dev, will then run full post processing , and copy to google drive

jcaracappa1 commented 6 months ago

Found and fixed error in at_biology.prm BHbeta_WHK was 3.25+14 instead of 3.25E14 Can anyone figure out what the diffs are for the at_harvest.prm. It says they're in the thousands of lines.

jcaracappa1 commented 5 months ago

After fixing the typo if BHalphaWHK from "3.25+14" to "3.25E14" it caused WHK to crash. I'm proposing we keep the "incorrect" version since it does result in normal recruitment and diagnose in next release.

andybeet commented 5 months ago

i agree. If i look at the diff, it looks like it was changed from E+14 to E14 which seems the opposite of what you'd want. unless i am reading that wrong. Was the change made in error?

jcaracappa1 commented 5 months ago

There was no "E" previously.

RGamble1 commented 5 months ago

This looks good to me - except the weird WHK recruitment parameter. But I agree with Joe, we can fix in the next release