search

NEFSC / READ-SSB-CHAJI-Effort-Displacement---Scallop

Other
0 stars 0 forks source link

2022 dollars and scallop vignette data. #228

Open mle2718 opened 12 months ago

mle2718 commented 12 months ago

After the tiny report is merged into main, the data_process_vignette code will not work because it looks for DOLLAR_2020, not DOLLAR_2022.

https://github.com/NEFSC/READ-SSB-CHAJI-Effort-Displacement---Scallop/blob/89e7d5782764ac2dc88b2640d92509f58243bcb8/data_wrangle/vignette_data_process.Rmd#L85-L89

We could

  1. Pull along a DOLLAR_2020 column from the data processing table.
  2. Not do that and just force people to use DOLLAR_2022

Any thoughts?

The FishSET people are using this, so I'm not 100% sure of the best solution here yet.

mchaji commented 12 months ago

I changed the all the code (processing, tiny report, scallop report etc.) in the tiny report branch to use DOLLAR_2022, so I could use the updated results in the paper. But I'm open to making changes if isn't the best fit long term.

mle2718 commented 12 months ago

I changed the all the code (processing, tiny report, scallop report etc.) in the tiny report branch to use DOLLAR_2022, so I could use the updated results in the paper. But I'm open to making changes if isn't the best fit long term.

Understood and that's fine.

The vignette_data_process.Rmd was not changed -- but don't make any changes to it.

This is partially a placeholder issue for when I try to re-run the vignette_data_process.Rmd in the future.