search

NEFSC / READ-SSB-CHAJI-Effort-Displacement---Scallop

Other
0 stars 0 forks source link

knit tiny loop bug #252

Open mle2718 opened 9 months ago

mle2718 commented 9 months ago 
          @Ardini-NOAA is getting the following error from running the tiny loop

image

Originally posted by @mchaji in https://github.com/NEFSC/READ-SSB-CHAJI-Effort-Displacement---Scallop/issues/235#issuecomment-1936150088

mle2718 commented 9 months ago

@Ardini-NOAA -- Starting with "restart R", please describe the full sequence of events that lead to this error message.

We've never seen this error message.

mle2718 commented 9 months ago

EDIT -- it was not the problem.

https://github.com/NEFSC/READ-SSB-CHAJI-Effort-Displacement---Scallop/blob/7c72ea7aa43ddb4cdc0bac5d7bf75f69b12f300d/analysis_code/scallop_analysis_tiny_report.Rmd#L1152

@mchaji -- I think this is the problem

you put it in here: https://github.com/NEFSC/READ-SSB-CHAJI-Effort-Displacement---Scallop/commit/b98784f8796314c06a2b811f4abea86935bbae15

any idea what's going on?

mle2718 commented 9 months ago

EDIT -- it was not the problem, although it is a bug.

Problem is actually here https://github.com/NEFSC/READ-SSB-CHAJI-Effort-Displacement---Scallop/blob/7c72ea7aa43ddb4cdc0bac5d7bf75f69b12f300d/analysis_code/scallop_analysis_tiny_report.Rmd#L1143

Because it doesn't line up with 

    - wind_NY1.RDS
    - wind_NY2.RDS
    - wind_NY3.RDS
    - wind_Central_Atlantic_1.RDS
    - wind_Central_Atlantic_2.RDS
    - wind_Central_Atlantic_3.RDS
    - wind_sf_final.RDS
    - wind_sf_nocable.RDS
    - wind_sf_combined.RDS
Ardini-NOAA commented 9 months ago

Right, should line 1143 be changed to these: "wind_sf_combined.RDS","wind_NY1.RDS","wind_NY2.RDS","wind_NY3.RDS","wind_Central_Atlantic_1.RDS","wind_Central_Atlantic_2.RDS","wind_Central_Atlantic_3.RDS"

Do we use wind_sf_final.RDS and wind_sf_nocable.RDS?

Ardini-NOAA commented 9 months ago

I'm still confused about what caused the error. The loop worked for me on 2/7. Maybe those other input datasets used to exist but are now deleted?

mle2718 commented 9 months ago

problem is actually from edits to the combine_cable_routes.Rmd See #256

mle2718 commented 9 months ago

Right, should line 1143 be changed to these: "wind_sf_combined.RDS","wind_NY1.RDS","wind_NY2.RDS","wind_NY3.RDS","wind_Central_Atlantic_1.RDS","wind_Central_Atlantic_2.RDS","wind_Central_Atlantic_3.RDS"

Do we use wind_sf_final.RDS and wind_sf_nocable.RDS?

Fixed in 43f4e0f0aeaa6a3cd6dc0cfed112452b96da3ed9

We are supposed to run the scallop analysis on "wind_sf_nocable.RDS"

a84b86f49d54913a4b6585ce19d7b787045d000b