search

NEON-biodiversity / Ostats

O-statistics (community pairwise niche overlap statistics)
https://neon-biodiversity.github.io/Ostats/
Other
7 stars 2 forks source link

overlap calculated separately for >1 trait #15

Closed qdread closed 3 years ago

qdread commented 4 years ago

The Ostats() function now rejects input with >1 trait (line 106). However if you look at line 151, you can see that actually it should loop through the traits and calculate a separate overlap for each trait.

We need to get rid of that error catching line because we don't want it to return an error if there is >1 trait. We want it to either calculate a separate overlap for each trait, or ultimately also implement the hypervolume overlap for >1 trait. See #14 for more on hypervolumes.

qdread commented 3 years ago

I just noticed that the community_overlap_merged() function is written so that it currently returns an error if there is >1 trait due to the way the data structures are set up. This function will also need to be rewritten to support the multiple traits (not just for the hypervolumes but also just to be able to loop through >1 trait).

qdread commented 3 years ago

I resolved these issues in the set of commits I merged from hypervolume test branch into master branch: 866db1d