Closed rfiorella closed 1 year ago
A few issues I noticed after opening the PR:
1) There may be an issue with with second/millisecond parsing here that needs to be checked: https://stackoverflow.com/questions/71505467/r-fastposixct-milliseconds-not-parsed-correctly-and-time-zone-inconsistency - may not be an issue if slightly lower precision is permissible (e.g., to 1/10th second).
2) format argument is not used by fasttime::fastPOSIXct, because the format is assumed and fixed: https://cran.r-project.org/web/packages/fasttime/fasttime.pdf - I'll correct if this route seems viable
Incorporated with slight modifications.
Replaces as.POSIXct with fasttime::fastPOSIXct to speed up POSIXct conversions in stackEddy. as.POSIXct seems to slow dramatically when vector to convert is very large - this change cuts runtime for stackEddy on L1/9 minute stack by roughly half.