search

NEONScience / NEON-utilities

Utilities and scripts for working with NEON data. Currently: an R package with functions to join (stack) the month-by-site files in downloaded NEON data, to convert data to geoCSV format, and to download data from the API.
GNU Affero General Public License v3.0
57 stars 36 forks source link

getReadmePublicationDate seems to output many duplicates of each readme #95

Closed eshrh closed 4 years ago

eshrh commented 4 years ago

Function Which of the functions in the neonUtilities package is this bug found in? stackByTable/getReadmePublicationDate

Describe the bug The stacked readme file contains several duplicate rows of each instance of a readme checked.

To Reproduce Download tick data, DP1.10093.001, over a time range: say 2016-01-01 to 2019-31-1 from OSBS. The readme file, in the post-stacking section, contains 31 unique rows that are repeated 89-90 times each. This leads to a readme file that is about 2,800 lines long in total.

Expected behavior The stacked readme contains only a unique list of the 31 readmes considered.

System (please complete the following information):

I might try to submit a patch soon.

cklunch commented 4 years ago

@eshrh Thanks for the heads up. @NateMietk Can you look into this?

NateMietk commented 4 years ago

@cklunch yup - I can look into this Wednesday or Thursday.

cklunch commented 4 years ago

@eshrh This is now fixed on GitHub, thanks @NateMietk ! We'll close the issue when the fix is on CRAN.

cklunch commented 4 years ago

@eshrh This fix is now live on CRAN, thanks for letting us know about it!