search

NEORIS-ZDEVOPS / DS-Editor

VS Code Extensions - DS Editor. An integrated Data-Set Editor for Visual Studio Code.
Apache License 2.0
1 stars 0 forks source link

Cannot edit some fields #2

Closed jhuddle61 closed 1 year ago

jhuddle61 commented 1 year ago

Some of the fields in my dataset are shown in yellow and will not allow me to save changes to those fields. Is there something I can do to allow these fields to be editable?

image

jhuddle61 commented 1 year ago

Found that fields defined as PIC 9 will not save edits. Is this by design?

antonkc commented 1 year ago

No, It should be editable. Today I am on vacation, I will try to recreate this problem tomorrow. Further information then.

jhuddle61 commented 1 year ago

More info, I tried with a couple of values, one date and one integer both PIC 9, zeroes were saved for the value versus what I typed.

antonkc commented 1 year ago

It may be because the input is not validating. A better feedback system is in my backlog for these potential cases. Can you provide the full PIC and what numbers you tried to type in?

antonkc commented 1 year ago

Error reproduced

antonkc commented 1 year ago

Fix will roll in the next version. We plan to deploy a minor one this friday.

jhuddle61 commented 1 year ago

Did the minor release get pushed last Friday?

antonkc commented 1 year ago

No, sorry. The code is ready, so I expect it to be published soon. The version number will 1.4.1 then.

PD: I didn't forget about this issue. You can expect an update as soon as the version rolls out.

antonkc commented 1 year ago

Some pipeline work must be done here, sorry. The one that uploads the artifact is a management person. I will try to get clearance to do it myself or with some script. Meanwhile, I am still stuck waiting with you.

I was too enthusiastic about the first issue opened by users that I jumped to giving dates without checking with said business person. Mistake on me.

Like a said before, I did not forget this issue and I will inform you as soon as it is realeased.

antonkc commented 1 year ago

Okey, @jhuddle61. The minor version just rolled out. I will update the repo tomorrow since today is getting a bit late. You should be able to edit these fields already.

antonkc commented 1 year ago

I will close this issue since the version 1.4.1 fixes it.