NERC-CEH / fit-count-app

Fit Count App & Website
Apache License 2.0
0 stars 0 forks source link

FITCount App - Chile to Live #165

Closed JimChiazzese1 closed 1 year ago

JimChiazzese1 commented 1 year ago

Hi Karolis, Chile have reviewed thoroughly and are happy to move live. As with Croatia, I assume we should copy the existing english terms/conditions to the URLs below for Chile?

Thanks Jim

kazlauskis commented 1 year ago

Thanks, I'll work on this next week then 👍

kazlauskis commented 1 year ago

I've done my bit now. Someone should still add the Spanish website pages.

JimChiazzese1 commented 1 year ago

Thanks @kazlauskis - Although Spanish website pages we'll need pages for Chile rather than Spanish, as Spain will also be joining and potentially have different translations/information on their pages, so i'll request Biren creates: https://fitcount.ceh.ac.uk/cl/terms https://fitcount.ceh.ac.uk/cl/privacy-notice

Thanks

JimChiazzese1 commented 1 year ago

Sorry @kazlauskis - That should of read "should we request Biren creates....." What are your thoughts on this. We'll need to seperate Chile Spanish from Spanish Spanish at some point, the same as we have we Portuguese. What do you suggest?

kazlauskis commented 1 year ago

At the moment, the links are generated using the IETF language codes, this actually directly comes directly from Transifex. It's essentially language+region, like en (whole world), pt-BR (Brazil), pt-PT (Portugal). So let's create es-CL for Chile, then.

DavidRoy commented 1 year ago

Agreed. This is how Drupal will work too

JimChiazzese1 commented 1 year ago

Hi @kazlauskis - Biren created the pages below with the duplicated UK terms/privacy https://fitcount.ceh.ac.uk/es-CL/terms https://fitcount.ceh.ac.uk/es-CL/privacy-notice These will need updating on the app

kazlauskis commented 1 year ago

This is done in the app. For some reason, the website links point to missing pages for me.

BirenRathod commented 1 year ago

@kazlauskis you need to use lowercase for Chile like es-cl in the link.

kazlauskis commented 1 year ago

@BirenRathod Is this for Chile only, or do you use lowercase codes for every country?

BirenRathod commented 1 year ago

@kazlauskis No. lowercase is standardised thorough out the Drupal site on Pantheon.